Skip to content

fix: prop handling on native Android implementation#592

Merged
jokerttu merged 4 commits into
mainfrom
fix/timing-issue-on-ios-mapview-initialization
May 19, 2026
Merged

fix: prop handling on native Android implementation#592
jokerttu merged 4 commits into
mainfrom
fix/timing-issue-on-ios-mapview-initialization

Conversation

@jokerttu
Copy link
Copy Markdown
Contributor

@jokerttu jokerttu commented May 15, 2026

Fixes how view controller props are set on view initialization on Android platform

Fixes #590
Fixes #582

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

@jokerttu jokerttu requested a review from illuminati1911 May 15, 2026 09:18
jokerttu
jokerttu commented May 15, 2026
View reviewed changes
Comment thread android/src/main/java/com/google/android/react/navsdk/NavViewManager.java
Comment on lines -378 to -380
if (fragment.getMapController() != null) {
sink.applyToController(fragment.getMapController());
}
Copy link
Copy Markdown
Contributor Author

@jokerttu jokerttu May 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@illuminati1911 this PR fixes situation where controller was not ready, and therefore controller settings on the sink were never applied.

@jokerttu jokerttu marked this pull request as ready for review May 18, 2026 09:11
@qwalker8408-aura
Copy link
Copy Markdown

qwalker8408-aura commented May 18, 2026 •
edited
Loading

Hello @jokerttu , I just want to know something please... Is the IOS fix probably coming in a different PR ?

@illuminati1911 illuminati1911 force-pushed the fix/timing-issue-on-ios-mapview-initialization branch from 7104313 to 0b7d035 Compare May 19, 2026 06:37
@illuminati1911 illuminati1911 force-pushed the fix/timing-issue-on-ios-mapview-initialization branch from 0b7d035 to cc5403c Compare May 19, 2026 06:38
illuminati1911
illuminati1911 approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@illuminati1911 illuminati1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu jokerttu merged commit 931f23c into main May 19, 2026
12 checks passed
@jokerttu jokerttu deleted the fix/timing-issue-on-ios-mapview-initialization branch May 19, 2026 07:17
@googlemaps-bot googlemaps-bot mentioned this pull request May 19, 2026
Open
@illuminati1911
Copy link
Copy Markdown
Contributor

illuminati1911 commented May 20, 2026

Hello @jokerttu , I just want to know something please... Is the IOS fix probably coming in a different PR ?

Hey @qwalker8408-aura. That would be in a different PR yes. Could you tell me what kind of issues you are running into on iOS?

@qwalker8408-aura
Copy link
Copy Markdown

qwalker8408-aura commented May 20, 2026

Hello @jokerttu , I just want to know something please... Is the IOS fix probably coming in a different PR ?

Hey @qwalker8408-aura. That would be in a different PR yes. Could you tell me what kind of issues you are running into on iOS?

Hey @illuminati1911 👋 . Its when I want to toggle myLocationEnabled (the location puk) programmatically (when my state changes).

When I do this on android all I have to do is in the onMapReady to do a setTimeout for as little as 100ms and if i toggle state to change the myLocationEnabled it does disappear/show but the same approach for IOS never does.

Apologies, I wish more insight could be provided with native insights but not my strength.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illuminati1911 illuminati1911 illuminati1911 approved these changes

Assignees

@illuminati1911 illuminati1911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: myLocationEnabled not working [Bug]: Widgets do not show up when enabled

3 participants

@jokerttu @qwalker8408-aura @illuminati1911