feat: Migrates deckgl-points to js-api-samples.#1195
Open
feat: Migrates deckgl-points to js-api-samples.#1195
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
These were added during troubleshooting, but it appears they're not needed.
Was I wrong to remove them?
miraleung
approved these changes
Mar 17, 2026
Updated Deck.gl dependencies to version 9.2.10. If ALL of them don't have the same dependencies, BAD THINGS HAPPEN.
Added dependencies for @luma.gl/core and @luma.gl/engine.
Removed dependencies related to deck.gl and luma.gl. Luma is a subdependency and shouldn't need to be declared; deck.gl has been moved to the root package.json file.
My experiment of having them at root failed.
Refactor point radius and fill color logic to validate earthquake features.
Removed commented-out type definition for Feature.
Updated dependencies for @deck.gl packages to version 8.9.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following things: