fix: validate resource name to prevent path traversal in Documents op…#2338
Open
brodmart wants to merge 2 commits intogoogleapis:mainfrom
Open
fix: validate resource name to prevent path traversal in Documents op…#2338brodmart wants to merge 2 commits intogoogleapis:mainfrom
brodmart wants to merge 2 commits intogoogleapis:mainfrom
Conversation
…erations
Documents.get and Documents.delete (sync and async) pass the caller-supplied
`name` parameter directly into `format_map` with no sanitization. A name
containing `..` sequences can traverse outside the intended resource path.
Add a lightweight `_validate_resource_name()` guard that raises ValueError
on any name containing `..` before the URL is constructed.
Fixes a path traversal reported via Google VRP (report 503098362).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erations
Documents.get and Documents.delete (sync and async) pass the caller-supplied
nameparameter directly intoformat_mapwith no sanitization. A namecontaining
..sequences can traverse outside the intended resource path.Add a lightweight
_validate_resource_name()guard that raises ValueErroron any name containing
..before the URL is constructed.Fixes a path traversal reported via Google VRP (report 503098362).