fix: align app_name with Cloud ML Job ID in deployed environments#6624
Open
EaCognitive wants to merge 4 commits intogoogleapis:mainfrom
Open
fix: align app_name with Cloud ML Job ID in deployed environments#6624EaCognitive wants to merge 4 commits intogoogleapis:mainfrom
EaCognitive wants to merge 4 commits intogoogleapis:mainfrom
Conversation
Author
|
Updated with current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an
AdkAppis deployed to Vertex AI Agent Engine, there is often a mismatch between the localapp.nameand the Resource ID assigned by the backend. The SDK currently uses the local name for artifact lookups, leading to 404 errors because the deployment infrastructure expects the Resource ID.Solution
Updated
AdkApp._app_name()to check for theCLOUD_ML_JOB_IDenvironment variable. If present (indicating a deployed environment), the method returns this ID, ensuring consistency with the backend's expectations for artifact storage and lookup.Changes
vertexai/agent_engines/templates/adk.py: Added environment variable check to_app_name().Verification