feat: recycle channel on consecutive new stream failures#2903
Open
feat: recycle channel on consecutive new stream failures#2903
Conversation
product-auto-label
Bot
added
size: m
mutianf
reviewed
Apr 30, 2026
| } else if (!status.isOk() && status.getCode() != Code.CANCELLED) { | ||
| channelWrapper.consecutiveFailures++; | ||
| } | ||
| releaseChannel(channelWrapper, status); |
Contributor
There was a problem hiding this comment.
Not related to this PR, but I feel releaseChannel should be called releaseStream or something, with recycleChannel the naming gets a little confusing..
| } | ||
|
|
||
| private static boolean shouldRecycleChannel(Status status) { | ||
| private static boolean shouldRecycleChannel(ChannelWrapper channelWrapper, Status status) { |
Contributor
There was a problem hiding this comment.
Also unrelated to this PR.. I'm wondering how this works..
if we get unimplemented, shouldn't the client fallback to unary? (iiuc which doesn't use this channel pool) recycling the channel and try to create a new one likely still won't work?
| private static final String DEFAULT_LOG_NAME = "pool"; | ||
| private static final AtomicInteger INDEX = new AtomicInteger(); | ||
|
|
||
| private static final int CONSECUTIVE_OPEN_FAILURE_THRESHOLD = 5; |
Contributor
There was a problem hiding this comment.
wondering if this should be called CONSECUTIVE_OPEN_SESSION_FAILURE_THRESHOLD.
And I think this should come from client config?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.