chore(pubsub): Add sample for subscribe avro records with revisions#33900
Merged
quartzmo merged 2 commits intogoogleapis:mainfrom May 1, 2026
Merged
chore(pubsub): Add sample for subscribe avro records with revisions#33900quartzmo merged 2 commits intogoogleapis:mainfrom
quartzmo merged 2 commits intogoogleapis:mainfrom
Conversation
The design is based on SubscribeWithAvroSchemaRevisionsExample.java: googleapis/java-pubsub#1469
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
aandreassa
reviewed
Apr 30, 2026
Contributor
aandreassa
left a comment
There was a problem hiding this comment.
Just a bunch of nits, but it looks good to go!
For new samples, we always strive for code readability over anything else. So that would something like no long lines, no nested arguments (within reason), descriptive comments. You got it though, LGTM!
aandreassa
approved these changes
May 1, 2026
Member
Author
|
@aandreassa Ruby 3.1 is no longer supported, correct? Is it OK to merge this PR despite the failing 3.1 check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sample for pubsub_subscribe_avro_records_with_revisions.
The design is based on SubscribeWithAvroSchemaRevisionsExample.java:
googleapis/java-pubsub#1469