Skip to content

chore: remove legacylibrarian generator#17590

Merged
codyoss merged 2 commits into
googleapis:mainfrom
codyoss:rm-lib-gen
Jun 29, 2026
Merged

chore: remove legacylibrarian generator#17590
codyoss merged 2 commits into
googleapis:mainfrom
codyoss:rm-lib-gen

Conversation

@codyoss

@codyoss codyoss commented Jun 29, 2026

Copy link
Copy Markdown
Member

This project now uses release-please for all releasing which was the last usage of the legacylibrarian system. This code may now be deleted.

Internal Bug: b/524618595

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the entire .generator directory, deleting the generator's Dockerfile, CLI implementation (cli.py), test suite (test_cli.py), and Python dependency requirements. It also deletes the Cloud Build configuration files cloudbuild-dev.yaml and cloudbuild.yaml. As there are no review comments, I have no feedback to provide.

This project now uses release-please for all releasing which was
the last usage of the legacylibrarian system. This code may now
be deleted.

Internal Bug: b/524618595
@codyoss codyoss marked this pull request as ready for review June 29, 2026 19:53
@codyoss codyoss requested a review from a team as a code owner June 29, 2026 19:53
@codyoss

codyoss commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

If this gets approved I will remove the cloud build check before merging.

@parthea

parthea commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

LGTM, should we also remove skip_release from librarian.yaml ?

https://github.com/search?q=repo%3Agoogleapis%2Fgoogle-cloud-python%20skip_release&type=code

@codyoss codyoss requested a review from a team as a code owner June 29, 2026 20:08
@codyoss

codyoss commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

skip_release

Done, thanks!

@codyoss codyoss merged commit 58912bc into googleapis:main Jun 29, 2026
30 of 31 checks passed
@codyoss codyoss deleted the rm-lib-gen branch June 29, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants