fix(google-crc32c): add explicit license declaration to pyproject.toml#16807
Closed
anishesg wants to merge 1 commit intogoogleapis:mainfrom
Closed
fix(google-crc32c): add explicit license declaration to pyproject.toml#16807anishesg wants to merge 1 commit intogoogleapis:mainfrom
anishesg wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The `google-crc32c` package was missing a `license` field in the `[project]` section of `pyproject.toml` after being migrated from `setup.py`. Without this field, PyPI cannot display license metadata for the package, which breaks compliance checking workflows that validate open-source licenses during installation. Signed-off-by: anish k <ak8686@princeton.edu>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the pyproject.toml file for the google-crc32c package to explicitly include the license information as Apache 2.0. I have no feedback to provide as there were no review comments and the change is a standard metadata update.
Author
|
Closing — this repo requires internal multi-approver flow and a one-line metadata addition is unlikely to get through. Not worth the overhead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
google-crc32cpackage was missing alicensefield in the[project]section ofpyproject.tomlafter being migrated fromsetup.py. Without this field, PyPI cannot display license metadata for the package, which breaks compliance checking workflows that validate open-source licenses during installation.The fix adds
license = { text = "Apache 2.0" }topackages/google-crc32c/pyproject.toml, matching the license declaration format used by other libraries in this repo (e.g.,google-api-core). An audit of the otherpyproject.tomlfiles inpackages/found thatgoogle-crc32cis the only package with a[project]section that was missing this field.Fixes #16603