Skip to content

fix(google-crc32c): add explicit license declaration to pyproject.toml#16807

Closed
anishesg wants to merge 1 commit intogoogleapis:mainfrom
proudhare:fix/ph-issue-16603
Closed

fix(google-crc32c): add explicit license declaration to pyproject.toml#16807
anishesg wants to merge 1 commit intogoogleapis:mainfrom
proudhare:fix/ph-issue-16603

Conversation

@anishesg
Copy link
Copy Markdown

@anishesg anishesg commented Apr 24, 2026

The google-crc32c package was missing a license field in the [project] section of pyproject.toml after being migrated from setup.py. Without this field, PyPI cannot display license metadata for the package, which breaks compliance checking workflows that validate open-source licenses during installation.

The fix adds license = { text = "Apache 2.0" } to packages/google-crc32c/pyproject.toml, matching the license declaration format used by other libraries in this repo (e.g., google-api-core). An audit of the other pyproject.toml files in packages/ found that google-crc32c is the only package with a [project] section that was missing this field.

  • Open an issue (bug/issue) before writing code to discuss the change, evaluate designs, and agree on the general idea
  • Ensure tests and linter pass
  • Code coverage does not decrease (if source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #16603

The `google-crc32c` package was missing a `license` field in the `[project]` section of `pyproject.toml` after being migrated from `setup.py`. Without this field, PyPI cannot display license metadata for the package, which breaks compliance checking workflows that validate open-source licenses during installation.

Signed-off-by: anish k <ak8686@princeton.edu>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pyproject.toml file for the google-crc32c package to explicitly include the license information as Apache 2.0. I have no feedback to provide as there were no review comments and the change is a standard metadata update.

@anishesg anishesg marked this pull request as ready for review April 24, 2026 23:54
@anishesg anishesg requested a review from a team as a code owner April 24, 2026 23:54
@anishesg
Copy link
Copy Markdown
Author

Closing — this repo requires internal multi-approver flow and a one-line metadata addition is unlikely to get through. Not worth the overhead.

@anishesg anishesg closed this Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some libraries using pyproject.toml do not have explicit license declaration

1 participant