Skip to content

testing only - regenerating bigtable with legacylibrarian #16709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jskeet wants to merge 2 commits into from
Closed

testing only - regenerating bigtable with legacylibrarian #16709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda5a91
chore: configure legacylibrarian to be able to generate bigtable
jskeet Apr 17, 2026
f0546d5
chore: regenerated with legacylibrarian
jskeet Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .librarian/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# This file is being migrated to librarian@latest, and is no longer maintained by hand.

release_only_mode: true
global_files_allowlist:
- path: CHANGELOG.md
permissions: read-write
Expand All @@ -10,8 +9,6 @@ libraries:
- generate_blocked: true
id: google-cloud-storage
release_blocked: true
- generate_blocked: true
id: google-cloud-bigtable
- generate_blocked: true
id: bigframes
release_blocked: true
Expand Down
2 changes: 1 addition & 1 deletion .librarian/state.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,7 +1166,7 @@ libraries:
tag_format: '{id}-v{version}'
- id: google-cloud-bigtable
version: 2.36.0
last_generated_commit: a6cbf809c4c165e618ee23a059442af90a80a0f5
last_generated_commit: 1a00cecd9a90ac056247d5b522e94af5347adc1d
apis:
- path: google/bigtable/admin/v2
service_config: bigtableadmin_v2.yaml
Expand Down
41 changes: 41 additions & 0 deletions packages/google-cloud-bigtable/google/cloud/bigtable_admin_v2/types/instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ class Instance(proto.Message):
instance.
type_ (google.cloud.bigtable_admin_v2.types.Instance.Type):
The type of the instance. Defaults to ``PRODUCTION``.
edition (google.cloud.bigtable_admin_v2.types.Instance.Edition):
Optional. The edition of the instance. See
[Edition][google.bigtable.admin.v2.Instance.Edition] for
details.
labels (MutableMapping[str, str]):
Labels are a flexible and lightweight mechanism for
organizing cloud resources into groups that reflect a
Expand Down Expand Up @@ -146,6 +150,38 @@ class Type(proto.Enum):
PRODUCTION = 1
DEVELOPMENT = 2

class Edition(proto.Enum):
r"""Possible editions of an instance.

An edition is a specific tier of Cloud Bigtable. Each edition is
tailored to different customer needs. Higher tiers offer more
features and better performance.

Values:
EDITION_UNSPECIFIED (0):
The edition is unspecified. This is treated as
``ENTERPRISE``.
ENTERPRISE (1):
The Enterprise edition. This is the default
offering that is designed to meet the needs of
most enterprise workloads.
ENTERPRISE_PLUS (2):
The Enterprise Plus edition. This is a
premium tier that is designed for demanding,
multi-tenant workloads requiring the highest
levels of performance, scale, and global
availability.

The nodes in the Enterprise Plus tier come at a
higher cost than the Enterprise tier. Any
Enterprise Plus features must be disabled before
downgrading to Enterprise.
"""

EDITION_UNSPECIFIED = 0
ENTERPRISE = 1
ENTERPRISE_PLUS = 2

name: str = proto.Field(
proto.STRING,
number=1,
Expand All @@ -164,6 +200,11 @@ class Type(proto.Enum):
number=4,
enum=Type,
)
edition: Edition = proto.Field(
proto.ENUM,
number=14,
enum=Edition,
)
labels: MutableMapping[str, str] = proto.MapField(
proto.STRING,
proto.STRING,
Expand Down
22 changes: 17 additions & 5 deletions packages/google-cloud-bigtable/google/cloud/bigtable_admin_v2/types/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,20 @@ class AutomatedBackupPolicy(proto.Message):
Attributes:
retention_period (google.protobuf.duration_pb2.Duration):
Required. How long the automated backups
should be retained. The only supported value at
this time is 3 days.
should be retained. Values must be at least 3
days and at most 90 days.
frequency (google.protobuf.duration_pb2.Duration):
Required. How frequently automated backups
should occur. The only supported value at this
time is 24 hours.
How frequently automated backups should
occur. The only supported value at this time is
24 hours. An undefined frequency is treated as
24 hours.
locations (MutableSequence[str]):
Optional. A list of Cloud Bigtable zones where automated
backups are allowed to be created. If empty, automated
backups will be created in all zones of the instance.
Locations are in the format
``projects/{project}/locations/{zone}``. This field can only
set for tables in Enterprise Plus instances.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: 'can only set' should be 'can only be set'.

Suggested change
set for tables in Enterprise Plus instances.
be set for tables in Enterprise Plus instances.

"""

retention_period: duration_pb2.Duration = proto.Field(
Expand All @@ -373,6 +381,10 @@ class AutomatedBackupPolicy(proto.Message):
number=2,
message=duration_pb2.Duration,
)
locations: MutableSequence[str] = proto.RepeatedField(
proto.STRING,
number=3,
)

name: str = proto.Field(
proto.STRING,
Expand Down
8 changes: 0 additions & 8 deletions packages/google-cloud-bigtable/google/cloud/bigtable_v2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@
Mutation,
PartialResultSet,
ProtoFormat,
ProtoRows,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The removal of ProtoRows, FeatureFlags, PeerInfo, and ResponseParams from the public API is a breaking change. If this is intentional, please ensure that a minor version bump is performed rather than a patch, in accordance with the rule that breaking changes require a minor version bump to maintain support for older environments.

References
  1. When a release introduces breaking changes, prefer a minor version bump over a patch version bump to maintain the ability to provide patches for the previous minor version.

ProtoRowsBatch,
ProtoSchema,
ReadModifyWriteRule,
Expand All @@ -82,15 +81,12 @@
Value,
ValueRange,
)
from .types.feature_flags import FeatureFlags
from .types.peer_info import PeerInfo
from .types.request_stats import (
FullReadStatsView,
ReadIterationStats,
RequestLatencyStats,
RequestStats,
)
from .types.response_params import ResponseParams
from .types.types import Type

if hasattr(api_core, "check_python_version") and hasattr(
Expand Down Expand Up @@ -200,7 +196,6 @@ def _get_version(dependency_name):
"ExecuteQueryRequest",
"ExecuteQueryResponse",
"Family",
"FeatureFlags",
"FullReadStatsView",
"GenerateInitialChangeStreamPartitionsRequest",
"GenerateInitialChangeStreamPartitionsResponse",
Expand All @@ -211,13 +206,11 @@ def _get_version(dependency_name):
"MutateRowsResponse",
"Mutation",
"PartialResultSet",
"PeerInfo",
"PingAndWarmRequest",
"PingAndWarmResponse",
"PrepareQueryRequest",
"PrepareQueryResponse",
"ProtoFormat",
"ProtoRows",
"ProtoRowsBatch",
"ProtoSchema",
"RateLimitInfo",
Expand All @@ -231,7 +224,6 @@ def _get_version(dependency_name):
"ReadRowsResponse",
"RequestLatencyStats",
"RequestStats",
"ResponseParams",
"ResultSetMetadata",
"Row",
"RowFilter",
Expand Down
14 changes: 0 additions & 14 deletions packages/google-cloud-bigtable/google/cloud/bigtable_v2/types/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
Mutation,
PartialResultSet,
ProtoFormat,
ProtoRows,
ProtoRowsBatch,
ProtoSchema,
ReadModifyWriteRule,
Expand All @@ -65,21 +64,12 @@
Value,
ValueRange,
)
from .feature_flags import (
FeatureFlags,
)
from .peer_info import (
PeerInfo,
)
from .request_stats import (
FullReadStatsView,
ReadIterationStats,
RequestLatencyStats,
RequestStats,
)
from .response_params import (
ResponseParams,
)
from .types import (
Type,
)
Expand Down Expand Up @@ -118,7 +108,6 @@
"Mutation",
"PartialResultSet",
"ProtoFormat",
"ProtoRows",
"ProtoRowsBatch",
"ProtoSchema",
"ReadModifyWriteRule",
Expand All @@ -133,12 +122,9 @@
"TimestampRange",
"Value",
"ValueRange",
"FeatureFlags",
"PeerInfo",
"FullReadStatsView",
"ReadIterationStats",
"RequestLatencyStats",
"RequestStats",
"ResponseParams",
"Type",
)
23 changes: 0 additions & 23 deletions packages/google-cloud-bigtable/google/cloud/bigtable_v2/types/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"ColumnMetadata",
"ProtoSchema",
"ResultSetMetadata",
"ProtoRows",
"ProtoRowsBatch",
"PartialResultSet",
"Idempotency",
Expand Down Expand Up @@ -1442,28 +1441,6 @@ class ResultSetMetadata(proto.Message):
)


class ProtoRows(proto.Message):
r"""Rows represented in proto format.

This should be constructed by concatenating the ``batch_data`` from
each of the relevant ``ProtoRowsBatch`` messages and parsing the
result as a ``ProtoRows`` message.

Attributes:
values (MutableSequence[google.cloud.bigtable_v2.types.Value]):
A proto rows message consists of a list of values. Every N
complete values defines a row, where N is equal to the
number of entries in the ``metadata.proto_schema.columns``
value received in the first response.
"""

values: MutableSequence["Value"] = proto.RepeatedField(
proto.MESSAGE,
number=2,
message="Value",
)


class ProtoRowsBatch(proto.Message):
r"""A part of a serialized ``ProtoRows`` message.

Expand Down
125 changes: 0 additions & 125 deletions packages/google-cloud-bigtable/google/cloud/bigtable_v2/types/feature_flags.py
View file
Open in desktop

This file was deleted.

Loading
Loading