Skip to content

chore: remove duplicate per-package contribution and license files#7972

Merged
GautamSharda merged 10 commits intomainfrom
librarian-4273
Apr 10, 2026
Merged

chore: remove duplicate per-package contribution and license files#7972
GautamSharda merged 10 commits intomainfrom
librarian-4273

Conversation

@GautamSharda
Copy link
Copy Markdown
Contributor

@GautamSharda GautamSharda commented Apr 7, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/488768301 🦕

For googleapis/librarian#4273

@GautamSharda GautamSharda requested a review from a team as a code owner April 7, 2026 19:39
GautamSharda and others added 6 commits April 7, 2026 23:14
This reverts the following commits because the issues were fixed externally:
- 4671b3f: fix(apigeeregistry): skip failing quickstart test
- ae52412: fix(storage-control): type conflict between @sinonjs/fake-timers and @types/sinonjs__fake-timers
- 1ee8974: fix(area120-tables): skip failing quickstart test
@pearigee
Copy link
Copy Markdown
Contributor

pearigee commented Apr 9, 2026

To make these changes permanent, we will also need to update the generator to prevent them from being re-added.

Also, I disabled the system/sample tests that were breaking you above. You should be able to revert those changes.

For the fake-timers issue I have this PR in progress to resolve the problem going forward: #7995

GautamSharda and others added 3 commits April 9, 2026 21:28
…kages

To prevent `LICENSE`, `CONTRIBUTING.md`, and `CODE_OF_CONDUCT.md` from being re-added to individual packages after they were removed in PR #..., this updates the gapic generator templates to stop generating them.
Also updates `README.md.njk` to point to the root-level `LICENSE` and `CONTRIBUTING.md`.
@GautamSharda GautamSharda merged commit 6b4a203 into main Apr 10, 2026
37 checks passed
@GautamSharda GautamSharda deleted the librarian-4273 branch April 10, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants