test diffs#13355
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the Java client library and its associated artifacts from google-cloud-developer-knowledge to google-developers-knowledge, updating metadata, documentation, and generating the client code under the new package com.google.developers.knowledge.v1. The review feedback highlights two issues: a potential Maven build failure due to a missing parent POM update for the renamed parent artifact ID, and a mismatch between the VERSION constant in Version.java and the POM files which would affect telemetry reporting.
| <parent> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-developers-knowledge-parent</artifactId> | ||
| <version>0.1.0-SNAPSHOT</version><!-- {x-version-update:google-developers-knowledge:current} --> | ||
| </parent> |
There was a problem hiding this comment.
The parent POM artifact ID is specified as google-developers-knowledge-parent. However, the parent POM file at java-developerknowledge/pom.xml is not included in this pull request. If java-developerknowledge/pom.xml has not been updated to use this new artifact ID (renamed from google-cloud-developer-knowledge-parent) and to include the renamed modules, the Maven build will fail due to an unresolved parent dependency.
| @InternalApi("For internal use only") | ||
| final class Version { | ||
| // {x-version-update-start:google-developers-knowledge:current} | ||
| static final String VERSION = "0.0.0-SNAPSHOT"; |
There was a problem hiding this comment.
The VERSION constant is set to '0.0.0-SNAPSHOT', but the library version in the POM files is '0.1.0-SNAPSHOT'. This mismatch will cause the library to report an incorrect version in the user-agent telemetry header. Update this constant to match the current POM version.
| static final String VERSION = "0.0.0-SNAPSHOT"; | |
| static final String VERSION = "0.1.0-SNAPSHOT"; |
1 participant
No description provided.