Skip to content

ci(generation): skip files inheriting coordinates in release check#12850

Open
meltsufin wants to merge 2 commits intomainfrom
fix-release-check-inheritance
Open

ci(generation): skip files inheriting coordinates in release check#12850
meltsufin wants to merge 2 commits intomainfrom
fix-release-check-inheritance

Conversation

@meltsufin
Copy link
Copy Markdown
Member

Fixes #12840

@meltsufin meltsufin requested a review from a team as a code owner April 18, 2026 03:40
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the check_existing_release_versions.sh script to skip POM files that lack explicit group_id or version declarations, treating them as inheriting coordinates rather than errors. Feedback suggests reordering the validation logic to ensure the mandatory artifact_id is checked first, preventing the script from incorrectly skipping malformed files, and improving the formatting of error messages.

Comment thread generation/check_existing_release_versions.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

existing-versions-check failed in release PR

1 participant