build: fall back to previous image version on release PRs#12848
build: fall back to previous image version on release PRs#12848
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback mechanism for the hermetic library generation script. When a release PR branch is detected, the script attempts to pull the specified Docker image; if it fails, it tries to extract and use the image tag from the target branch's workflow configuration. The review feedback suggests improving the robustness of the tag extraction logic to better handle potential multiple matches, comments, or colons within the YAML file.
6880d59 to
def6f2d
Compare
The library generation pipeline fails on release PRs because it attempts to pull a Docker image version that has not yet been built or pushed to the registry. This PR adds a fallback mechanism in hermetic_library_generation.sh to use the previous version of the image from the main branch if the requested version fails to pull on a release PR. To verify this in CI, this branch is named with the prefix 'release-please--' to simulate a release PR. Fixes #12825
def6f2d to
823b98c
Compare
|
Fallback validated in a separate release simulation PR #12849: |
|
|



The library generation pipeline fails on release PRs because it attempts to pull a Docker image version that has not yet been built or pushed to the registry.
This PR adds a fallback mechanism in hermetic_library_generation.sh to use the previous version of the image from the main branch if the requested version fails to pull on a release PR.
To verify this in CI, this branch is named with the prefix 'release-please--' to simulate a release PR.
Fixes #12825