Skip to content

test: auth change CI recognition #12846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
blakeli0 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test: auth change CI recognition #12846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d151ea
test: add dummy method to auth and use it in gax to test CI
blakeli0 Apr 17, 2026
4c6e4dc
test: call new auth method in bigquery, datastore, storage, and spanner
blakeli0 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions google-auth-library-java/credentials/java/com/google/auth/Credentials.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,9 @@ protected final void blockingGetToCallback(URI uri, RequestMetadataCallback call
* @throws IOException if there was an error getting up-to-date access.
*/
public abstract void refresh() throws IOException;

/** Dummy method to test CI recognition of auth changes. */
public String getTestString() {
return "test";
}
Comment on lines +198 to +201
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding a public method to the Credentials class modifies the library's public API. For a core class, introducing "dummy" methods can lead to maintenance issues and confusion for external consumers. If this method is required for cross-repository CI testing, it should be restricted using an annotation like @InternalApi or @VisibleForTesting to prevent it from being considered part of the stable public API.

}
1 change: 1 addition & 0 deletions ...-cloud-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,7 @@ private BigQuery getBigQueryConnection() {
bigQueryOptions.setProjectId(this.catalog);
}
if (this.credentials != null) {
this.credentials.getTestString();
bigQueryOptions.setCredentials(this.credentials);
}
if (this.location != null) {
Expand Down
1 change: 1 addition & 0 deletions ...-cloud-datastore/src/main/java/com/google/cloud/datastore/telemetry/EnabledTraceUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ public SpanBuilder addSettingsAttributesToCurrentSpan(SpanBuilder spanBuilder) {
.build());

if (datastoreOptions.getCredentials() != null) {
datastoreOptions.getCredentials().getTestString();
spanBuilder =
spanBuilder.setAttribute(
ATTRIBUTE_SERVICE_PREFIX + "settings.credentials.authenticationType",
Expand Down
1 change: 1 addition & 0 deletions ...r/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@ private void setupGcpFallback(
try {
Credentials credentials = credentialsProvider.getCredentials();
if (credentials != null) {
credentials.getTestString();
cloudPathBuilder.intercept(
new ClientInterceptor() {
@Override
Expand Down
1 change: 1 addition & 0 deletions ...orage/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ private Tuple<StorageSettings, Opts<UserProject>> resolveSettingsAndOpts() throw
Opts<UserProject> defaultOpts = Opts.empty();
CredentialsProvider credentialsProvider;
Preconditions.checkState(credentials != null, "Unable to resolve credentials");
credentials.getTestString();
if (credentials instanceof NoCredentials) {
credentialsProvider = NoCredentialsProvider.create();
} else {
Expand Down
3 changes: 3 additions & 0 deletions ...latform-java/gax-java/gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcCallContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,9 @@ public <T> T getOption(Key<T> key) {
@InternalApi
public void validateUniverseDomain() {
try {
if (credentials != null) {
credentials.getTestString();
}
Comment on lines +732 to +734
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The call to credentials.getTestString() is a no-op as the return value is not utilized. This introduces dead code into the validateUniverseDomain method. While this is a test PR, such code should not be present in the final implementation to avoid unnecessary execution overhead and maintain code clarity.

endpointContext.validateUniverseDomain(credentials, UNAUTHENTICATED_STATUS_CODE);
} catch (IOException e) {
// Check if it is an Auth Exception (All instances of IOException from endpointContext's
Expand Down
Loading