Skip to content

refactor: move iam-policy code to java-iam-policy folder#12834

Merged
chingor13 merged 2 commits intomainfrom
top-level-generated-artifacts
Apr 17, 2026
Merged

refactor: move iam-policy code to java-iam-policy folder#12834
chingor13 merged 2 commits intomainfrom
top-level-generated-artifacts

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Apr 17, 2026

This folder contains the google-cloud-iam-policy client

Towards #12735
Towards googleapis/librarian#5326

There is also an existing sdk-platform-java/java-iam folder which will need to move to the top level to be generated

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the IAM client library to IAM Policy across the configuration and project structure. Specifically, it updates generation_config.yaml to use iam-policy as the shortname and adds the api_id, while also renaming the Maven module from java-iam to java-iam-policy in the root pom.xml. I have no feedback to provide.

@chingor13 chingor13 marked this pull request as ready for review April 17, 2026 19:15
@chingor13 chingor13 requested a review from a team as a code owner April 17, 2026 19:15
@chingor13 chingor13 requested a review from blakeli0 April 17, 2026 19:15
@chingor13 chingor13 merged commit 4f2e50a into main Apr 17, 2026
110 checks passed
@chingor13 chingor13 deleted the top-level-generated-artifacts branch April 17, 2026 20:56
Comment thread generation_config.yaml
- proto_path: google/cloud/hypercomputecluster/v1
requires_billing: true
- api_shortname: iam
- api_shortname: iam-policy
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need to change the api_shortname?

@blakeli0
Copy link
Copy Markdown
Contributor

There are some assumptions in the hermetic build scripts regarding iam and common-protos, such as here and here. Can we test locally to make sure the hermetic build scripts can generate IAM correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants