test(bigquery): improve assertion in testLocationFastSQLQueryWithJobId#12815
Open
jinseopkim0 wants to merge 3 commits intomainfrom
Open
test(bigquery): improve assertion in testLocationFastSQLQueryWithJobId#12815jinseopkim0 wants to merge 3 commits intomainfrom
jinseopkim0 wants to merge 3 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the testLocationFastSQLQueryWithJobId integration test by adding explicit assertions to verify that the BigQuery job completed without errors and that the DML affected rows statistics are not null before performing value comparisons. I have no feedback to provide.
jinseopkim0
force-pushed
the
flaky-test-6
branch
from
6e25440 to
af2e041
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/467064827