Skip to content

chore(generator): migrate to std::optional#16230

Open
colinmoy wants to merge 3 commits into
googleapis:mainfrom
colinmoy:migrate-generator-optional
Open

chore(generator): migrate to std::optional#16230
colinmoy wants to merge 3 commits into
googleapis:mainfrom
colinmoy:migrate-generator-optional

Conversation

@colinmoy

@colinmoy colinmoy commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Replacing explicit usages of absl::optional with std::optional in the internal code generator toolchain (generator/) as part of broader modernization efforts

@colinmoy colinmoy requested a review from a team as a code owner July 1, 2026 21:12

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the usage of absl::optional and absl::nullopt to C++17's std::optional and std::nullopt across various generator, internal, and integration test files. I have no feedback to provide.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.26%. Comparing base (ce70c7d) to head (eb5abbf).

Files with missing lines Patch % Lines
generator/internal/descriptor_utils.cc 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16230      +/-   ##
==========================================
- Coverage   92.26%   92.26%   -0.01%     
==========================================
  Files        2214     2214              
  Lines      206307   206307              
==========================================
- Hits       190355   190352       -3     
- Misses      15952    15955       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@colinmoy colinmoy force-pushed the migrate-generator-optional branch from 22d6ff4 to 1be2a16 Compare July 1, 2026 23:03
@colinmoy colinmoy force-pushed the migrate-generator-optional branch from 1be2a16 to 145e397 Compare July 13, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants