-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore: Update discovery artifacts #2745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0aedc41
93dd8d1
7c70f58
867d11d
254d617
8b77092
9d7a211
6bd8141
a0022f4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,7 +116,7 @@ <h3>Method Details</h3> | |
| The object takes the form of: | ||
|
|
||
| { # *Deprecated:* New integrations cannot use this method and can refer to our new recommendations | ||
| "data": "A String", # The body of the private key credentials file, in string format. This is only populated when the ServiceAccountKey is created, and is not stored by Google. | ||
| "data": "A String", # The body of the private key credentials file, in string format. This is only populated when the ServiceAccountKey is created, and is not stored by Google. When type is "pkcs12", the contents of the data field is base64 encoded and has the password "notasecret". | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The documentation mentions a hardcoded password |
||
| "id": "A String", # An opaque, unique identifier for this ServiceAccountKey. Assigned by the server. | ||
| "publicData": "A String", # Public key data for the credentials file. This is an X.509 cert. If you are using the googleCredentials key type, this is identical to the cert that can be retrieved by using the X.509 cert url inside of the credentials file. | ||
| "type": "A String", # The file format of the generated key data. | ||
|
|
@@ -131,7 +131,7 @@ <h3>Method Details</h3> | |
| An object of the form: | ||
|
|
||
| { # *Deprecated:* New integrations cannot use this method and can refer to our new recommendations | ||
| "data": "A String", # The body of the private key credentials file, in string format. This is only populated when the ServiceAccountKey is created, and is not stored by Google. | ||
| "data": "A String", # The body of the private key credentials file, in string format. This is only populated when the ServiceAccountKey is created, and is not stored by Google. When type is "pkcs12", the contents of the data field is base64 encoded and has the password "notasecret". | ||
| "id": "A String", # An opaque, unique identifier for this ServiceAccountKey. Assigned by the server. | ||
| "publicData": "A String", # Public key data for the credentials file. This is an X.509 cert. If you are using the googleCredentials key type, this is identical to the cert that can be retrieved by using the X.509 cert url inside of the credentials file. | ||
| "type": "A String", # The file format of the generated key data. | ||
|
|
@@ -155,7 +155,7 @@ <h3>Method Details</h3> | |
| { | ||
| "serviceAccountKey": [ # The service account credentials. | ||
| { # *Deprecated:* New integrations cannot use this method and can refer to our new recommendations | ||
| "data": "A String", # The body of the private key credentials file, in string format. This is only populated when the ServiceAccountKey is created, and is not stored by Google. | ||
| "data": "A String", # The body of the private key credentials file, in string format. This is only populated when the ServiceAccountKey is created, and is not stored by Google. When type is "pkcs12", the contents of the data field is base64 encoded and has the password "notasecret". | ||
| "id": "A String", # An opaque, unique identifier for this ServiceAccountKey. Assigned by the server. | ||
| "publicData": "A String", # Public key data for the credentials file. This is an X.509 cert. If you are using the googleCredentials key type, this is identical to the cert that can be retrieved by using the X.509 cert url inside of the credentials file. | ||
| "type": "A String", # The file format of the generated key data. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation mentions a hardcoded password
notasecret. This is a significant security risk as it encourages the use of weak and well-known credentials. Hardcoded secrets should not be present in documentation. Please remove the mention of this password or add a strong warning that it is insecure and must not be used in production environments.