feat: Skip generation for services without RPC methods defined#1279
Open
aandreassa wants to merge 3 commits intomainfrom
Open
feat: Skip generation for services without RPC methods defined#1279aandreassa wants to merge 3 commits intomainfrom
aandreassa wants to merge 3 commits intomainfrom
Conversation
Contributor
Author
|
I tested this locally in |
When an API includes custom standalone LRO clients alongside ones using mixins like Location, the generator mistakenly tries to configure those mixins inside the LRO client itself. Since standard LRO clients don't actually support the `bindings_override` attribute, this caused crashes at startup due to a `NoMethodError`. This change adds a simple check to ensure we only try to pass that setting when the parent client actually defines it!
8bed731 to
a5fdbf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of empty service: google-cloud-dataplex-v1
fix: safely handle bindings_override passing in local LRO clients
When an API includes custom standalone LRO clients alongside ones using mixins like Location, the generator tries to configure those mixins inside the LRO client itself.
Since these LRO clients don't support the
bindings_overrideattribute, this causes crashes withNoMethodError. This change adds a simple check to ensure we only try to pass that setting when the parent client actually defines it.