Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
0bff7d7 to
542d72d
Compare
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
dbarnett
left a comment
There was a problem hiding this comment.
Could you see about adding a vroom test file with examples of rubocop's expected input/outputs, like other formatters have under the vroom/ directory?
| let l:formatted = split(l:result.stdout, "\n") | ||
|
|
||
| let l:before = a:startline > 1 ? l:lines[ : a:startline - 2] : [] | ||
| let l:full_formatted = l:before + l:formatted[1:] + l:lines[a:endline :] |
There was a problem hiding this comment.
This formatted[1:] is a little strange… does the formatter output an extra first line to stdout that's not part of the output?
Signed-off-by: Ari Archer <truncateddinosour@gmail.com>
|
Is anyone still working on this? I was about to start doing this when I found it already done and pending review. |
I suspect that David was waiting for a response to his question. If you want to take over and send a new PR that is reasonable |
Note: This change is based on an abandoned change by zinovyev #132
This pull request adds a rubocop support for Ruby and ERuby file types.
Solves #30