Skip to content

fix: don't report context cancelled errors & try report error string#4917

Merged
michaelkedar merged 2 commits intogoogle:masterfrom
michaelkedar:🙊⚠️
Feb 26, 2026

Hidden character warning

The head ref may contain hidden characters: "\ud83d\ude4a\u26a0\ufe0f"
Merged

fix: don't report context cancelled errors & try report error string#4917
michaelkedar merged 2 commits intogoogle:masterfrom
michaelkedar:🙊⚠️

Conversation

@michaelkedar
Copy link
Member

  1. Explicitly skip adding error reporting type to context.Cancelled errors, since they seem to be annoying
  2. Rename err/error slog fields to exception which is one of the fields error reporting looks for, so it might add it to the dashboard (I'm actually unsure if this works or not. I'm just experimenting tbh)

@michaelkedar michaelkedar merged commit da97efa into google:master Feb 26, 2026
20 checks passed
@michaelkedar michaelkedar deleted the 🙊⚠️ branch February 26, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants