fix(security): pin GitHub Actions to commit SHAs in publish workflow#67
Open
XananasX7 wants to merge 1 commit into
Open
fix(security): pin GitHub Actions to commit SHAs in publish workflow#67XananasX7 wants to merge 1 commit into
XananasX7 wants to merge 1 commit into
Conversation
Tag-pinned actions can be silently redirected to malicious code. Pin each action to its immutable commit SHA: - actions/checkout@v4 → @34e114876b0b11c390a56381ad16ebd13914f8d5 - actions/setup-python@v5 → @a26af69be951a213d495a4c3e4e4022e16d87065 - etils-actions/pypi-auto-publish@v1 → @e3c4b4afc3a5b12a44734da938741995538e8223 The pypi-auto-publish action has PYPI_API_TOKEN; a compromised tag would enable a supply-chain attack on every downstream user of mediapy.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pytest_and_autopublish.ymlworkflow uses mutable tag references for all three of its actions, includingetils-actions/pypi-auto-publish@v1— a third-party action with minimal vetting (~10 GitHub stars). If any tag is silently redirected, the malicious code runs in the job that holdsPYPI_API_TOKEN, enabling a backdoored release ofmediapyon PyPI.Changes
actions/checkout@v4@34e11487…actions/setup-python@v5@a26af69b…etils-actions/pypi-auto-publish@v1@e3c4b4af…SHA-pinning is recommended by the GitHub security hardening guide.