chore: Use golangci-lint-action; remove newreposecretwithlibsodium#4119
Conversation
9fabd9d to
cb6e035
Compare
golangci-lint-action; remove newreposecretwithlibsodium
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4119 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 211 211
Lines 19614 19614
=======================================
Hits 18382 18382
Misses 1034 1034
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| version: v2.10.1 # sync with version in .custom-gcl.yml | ||
| experimental: "automatic-module-directories" | ||
| - name: Check OpenAPI | ||
| run: ./script/metadata.sh update-openapi --validate |
There was a problem hiding this comment.
Does this mean that is it going to check the openapi YAML file every time? If so, I have a concern with this.
That YAML file gets updated frequently (daily?) on the GitHub side, and gets a new hash every time it changes, which would mean that we would be out-of-date with it most of them time.
As it currently stands, we have the freedom and flexibility to update our YAML file when it benefits us to do so, and I would like to continue with this luxury if possible.
There was a problem hiding this comment.
Yes. I didn't change the previous behaviour.
.script/lint.sh validates OpenAPI every time when running on GitHub Actions:
https://github.com/google/go-github/actions/runs/23317729164/job/67821480217#step:5:21
gmlewis
left a comment
There was a problem hiding this comment.
OK, excellent! That's perfect. I just didn't want an update.
Thank you, @alexandear!
LGTM.
Merging.
golangci/golangci-lint-actioninstead of./script/lint.sh. It automatically builds custom golangci-lint cache binaries with~/.cache/golangci-lint, and runs golangci-lint for each module.newreposecretwithxcryptoshould be enough.The cached lint step takes only 40 seconds:
Closes #4118
Updates #4070