Skip to content

ci: Ignore OAuth scopes in endpoint check #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
h-tsuboi918 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

ci: Ignore OAuth scopes in endpoint check #6245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions scripts/compliance_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,16 @@ def check_cli_import(content: str, filename: str) -> bool:
def check_mtls(content: str, filename: str) -> bool:
if filename in _EXCLUDED_FROM_MTLS:
return True
# Pattern for googleapis: https?://[a-zA-Z0-9.-]+\.googleapis\.com
endpoint_pattern = re.compile(r'https?://[a-zA-Z0-9.-]+\.googleapis\.com')
if endpoint_pattern.search(content):
endpoint_pattern = re.compile(
r'https?://[a-zA-Z0-9.-]+\.googleapis\.com[^"\'\s]*'
)
oauth_scope_pattern = re.compile(r'https?://www\.googleapis\.com/auth(/|$)')
endpoints = [
match.group(0)
for match in endpoint_pattern.finditer(content)
if not oauth_scope_pattern.match(match.group(0))
]
if endpoints:
return '.mtls.googleapis.com' in content
return True

Expand Down
Loading