fix: add a plan execution workflow for gemini-invoke workflow#465
Open
cynthialong0-0 wants to merge 5 commits intomainfrom
Open
fix: add a plan execution workflow for gemini-invoke workflow#465cynthialong0-0 wants to merge 5 commits intomainfrom
cynthialong0-0 wants to merge 5 commits intomainfrom
Conversation
Contributor
|
🤖 Hi @cynthialong0-0, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Contributor
There was a problem hiding this comment.
This PR successfully implements a two-stage workflow (plan vs. execute) to improve security and control over the Gemini agent's actions. The architectural separation is sound and the new plan-execute workflow is well-structured with appropriate permissions. However, there are critical configuration issues pointing to a personal fork that must be resolved before merging.
🔍 General Feedback
- Critical Configuration: Ensure all
usesdirectives point to the canonicalgoogle-github-actions/run-gemini-clirepository, not a personal fork. - User Experience: The instructions provided by the agent in the
invokephase must match the commands expected by thedispatchworkflow (e.g.,@gemini-cli /approve). - Context Handling: Consider capturing additional context provided during the approval step to allow users to provide final instructions or caveats to the execution agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a plan execution workflow which will execute the approved plans generated from gemini-invoke workflow. The new workflow will have content write permission which resolve the permission issues in the invoke workflow. This workflow will be triggered when
/approveis mentioned in the comments, and should refuse to execute if no plan being found in the issue comments.Changes
/approvecomment. If no plan of action exist in the issue, nothing with be executed. If there is a plan of action found, it will be executed. If there are multiple plan of action, it will execute the latest one.Fixes #382
Fixes #396