Add SceneTree::get_singleton()#2007
Open
Ijtihed wants to merge 1 commit into
Open
Conversation
Ijtihed
force-pushed
the
fix/scene-tree-get-singleton
branch
from
fa02843 to
7afa095
Compare
Author
|
It failed CI and now it shouldn't anymore :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
SceneTree::get_singleton()to godot-cpp which mirrors the method available to modules in Godot core. SceneTree is not a registered engine singleton so I implemented it like it was suggested in the issue (thanks to @dsnopek):the declaration is injected into the generated header with a binding_generator.py specias case. I added a test method and assertion to the integration test.
Fixes #1597
AI disclosure
I used claude to brainstorm then make sure I didn't miss any blind spots/repo conventions. All code was written and reviewed by me.