Create the task.dir before evaluating ShVars.#2813
Open
trulede wants to merge 1 commit intogo-task:mainfrom
Open
Create the task.dir before evaluating ShVars.#2813trulede wants to merge 1 commit intogo-task:mainfrom
trulede wants to merge 1 commit intogo-task:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some limited cases a ShVar may run commands which require the configured (not default) Task Dir to be created. This is especially the case if the ShVar attempts to access the parent folder of a Task with a configured Dir.
An attempt is made to create the Task Dir before the Task is compiled via
CompiledTask(). If this fails (i.e. Task Dir depends on a templated ShVar value) then the Task Dir will be created later, after the Task is compiled. The edge case that remains is not addressed by this PR.The testcase includes an example.
Fixes #1001
Alternative to #2800