fix: skip body encoding for all no-body HTTP status codes#1310
Open
Yanhu007 wants to merge 1 commit intogo-kit:masterfrom
Open
fix: skip body encoding for all no-body HTTP status codes#1310Yanhu007 wants to merge 1 commit intogo-kit:masterfrom
Yanhu007 wants to merge 1 commit intogo-kit:masterfrom
Conversation
EncodeJSONResponse only skips body encoding for 204 No Content, but HTTP spec (RFC 9110) requires no message body for 1xx, 204, and 304 responses. Writing a body for 304 Not Modified causes net/http to return an error. Extend the check to skip body encoding for 1xx, 204, and 304. Fixes go-kit#1291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1291
Problem
EncodeJSONResponseonly skips body encoding for204 No Content, but the HTTP specification (RFC 9110 §6.4.1, §15.3.5, §15.4.5) requires no message body for:When a response implements
StatusCoderand returns 304,json.NewEncoder(w).Encode()writes a body, causing net/http to return:Fix
Extend the no-body check to also cover 1xx and 304 status codes:
All existing tests pass.