Use system Prettier pre-commit hook#21483
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Reviewed the changes. Implementation looks solid: good code quality and consistency with established patterns (the migration to a Documentation review ran in docs-drift mode for this code-only change and found no required doc updates (drift risk: low). Low-risk determination: Escalate to human review
|
nandajavarma
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the Prettier pre-commit hook from the remote
pre-commit/mirrors-prettierNode hook to a locallanguage: systemhook that uses the preinstalledprettierbinary.It also pins
dev/npm-toolsto Prettier2.6.2, matching the previous hook version to avoid broad formatting churn, and removes the visiblenpxblocking stub from the dev image Dockerfiles because that blocking is handled elsewhere.Related Issue(s)
Fixes CORE-
How to test
pre-commit validate-configPATH="/workspace/gitpod/dev/npm-tools/node_modules/.bin:$PATH" pre-commit run prettier --all-files --verbosegit commitpassed for the staged changes.