Pin Docker version in devcontainer#21482
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
|
Reviewed the changes. Implementation looks solid: good code quality, appropriate test coverage, and follows established patterns. No significant concerns. The version pin is a clean, targeted fix that makes the dev environment more deterministic than the prior unpinned state. Docs review: ran a docs-drift check (code-only PR); no documentation updates are required, as this is internal contributor dev-environment configuration with no user-visible, API, CLI, or operational impact. Low-risk determination: Escalate to human review
|
corneliusludmann
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the
docker-in-dockerdevcontainer feature to Docker/Moby 28 instead of allowing the feature to install the current latest engine.The current unpinned setup installed Moby 29.4.3 with containerd 2.3.0. In this Ona environment, the feature-generated
docker-init.shleftdockerdunable to connect to its managed containerd process, causing Docker commands to fail withCannot connect to the Docker daemon at unix:///var/run/docker.sock.Validation
gitpod environment devcontainer validate .devcontainer/devcontainer.jsongitpod automations validate .gitpod/automations.yamlRebuild notes
I attempted devcontainer rebuilds after the config change. The Docker feature install step completed, but the runner failed during BuildKit image export with a containerd ref lock:
That failure happens after the devcontainer feature installation and appears to be a runner-side image export/cache issue rather than a schema or Docker configuration error.