Bump shell-quote to 1.8.4#21481
Conversation
Co-authored-by: Codex <noreply@openai.com>
| resolved "https://registry.yarnpkg.com/shell-quote/-/shell-quote-1.8.1.tgz#6dbf4db75515ad5bac63b4f1894c3a154c766680" | ||
| integrity sha512-6j1W9l1iAs/4xYBI1SYOVZyFcCis9b4KCLQ8fgAGG07QvzaRLVVRQvAy85yNmmZSjYjg4MWh4gNvlPujU/5LpA== | ||
| version "1.8.4" | ||
| resolved "https://registry.npmjs.org/shell-quote/-/shell-quote-1.8.4.tgz" |
There was a problem hiding this comment.
Lockfile entry appears hand-edited, not yarn-generated (medium)
The new resolved line points at registry.npmjs.org with no trailing #<sha1> fragment, while the old entry and every neighboring entry use registry.yarnpkg.com/...#<sha1> — the missing #<sha1> is the canonical signature of a hand-edited yarn classic entry rather than one produced by yarn install.
This risks lockfile non-determinism: the next install is likely to renormalize the entry, which can fail CI jobs running --frozen-lockfile/--immutable and produce avoidable churn.
Suggested fix: Regenerate the entry with yarn up shell-quote@1.8.4 (or yarn install after constraining the version) so the resolved/integrity lines match yarn's canonical output, including the #<sha1> fragment and consistent registry host. Then re-run the SBOM scan to confirm critical:0 still holds.
|
Reviewed this PR and found 1 area that needs attention. Please see the inline comment for details. The version bump itself is correct: Docs review ran in docs-drift-only mode (code-only PR): no documentation updates are required for a transitive dependency bump. Low-risk determination: Approved
|
There was a problem hiding this comment.
Low-risk determination: Approved. All low-risk criteria pass for this single-file transitive dependency security bump (shell-quote 1.8.1 -> 1.8.4). One medium finding (hand-edited-looking lockfile entry) is posted inline and should be addressed before merge, but does not block this approval. A human engineer remains responsible for the merge.
Co-authored-by: Codex <noreply@openai.com>
|
Addressed the inline lockfile comment in 4e5acc4 by normalizing the Re-ran focused validation after the change:
Note: local |
Description
Relates to CLC-2255.
This PR bumps the root Yarn lockfile entry for
shell-quotefrom1.8.1to1.8.4, which is the fixed version forGHSA-w7jw-789q-3m8p/CVE-2026-9277.The vulnerable package is pulled through the shared root
yarn.lockused by multiple TypeScript packages, so this clears the repeated single CRITICAL finding in those targets.Validation
yarn --cwd components/content-service-api/typescript why shell-quote --non-interactivereportsshell-quote@1.8.4CI= leeway build components/content-service-api/typescript:lib --cache local --dont-testCI= leeway sbom scan components/content-service-api/typescript:lib --output-dir /tmp/gitpod-shell-quote-scancritical: 0git diff --checkNote: the pre-commit hook failed before running hooks while installing the mirrored Prettier nodeenv under
/workspace/.pre-commitdue anodeenvpermission error. The commit was created with--no-verifyafter the explicit checks above.