Fix 2 crashes in singleShot timers while undocking tabs (especially in auto hide mode)#792
Open
UnlimitedStack wants to merge 1 commit intogithubuser0xFFFF:masterfrom
Conversation
…n auto hide mode)
Ext3h
reviewed
Feb 16, 2026
| QObject::connect(&DelayedAutoHideTimer, &QTimer::timeout, [this](){ | ||
| auto GlobalPos = DelayedAutoHideTab->mapToGlobal(QPoint(0, 0)); | ||
| qApp->sendEvent(DelayedAutoHideTab, new QMouseEvent(QEvent::MouseButtonPress, | ||
| QObject::connect(&DelayedAutoHideTimer, &QTimer::timeout, [this](){ |
There was a problem hiding this comment.
This should be using DelayedAutoHideTab as receiver context-object on the connection. The inner if is then unnecessary.
Ext3h
reviewed
Feb 16, 2026
| QPointer<CDockAreaTabBar> __this = _this; | ||
| QPointer<CDockWidgetTab> __tabWidget = TabWidget; | ||
|
|
||
| QTimer::singleShot(0, TabWidget, [__this, __tabWidget] |
There was a problem hiding this comment.
Which of the two variables was ever able to able to become a nullptr?
Either way - specify this as context-object on the connection, the inner if on __this is redundant.
QPointer<CDockWidgetTab> __tabWidget is fine, but should be constructed directly in the lambda arg.
There's still the possible edge case that TabWidget has been reparented in the meantime, but that's supported properly by ensureWidgetVisible, it's a NOOP if the target isn't a child.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first crash happens rarely while changing dock state programatically in startup phase.
The second one can be checked with the demo application. Just add the following line in the constructor of the demo:
CDockManager::setAutoHideConfigFlag(ads::CDockManager::AutoHideShowOnMouseOver, true);
Then attach a dock to the side bar (hide mode), select it and drag it anywhwere -> it crashes.