feat(integration): update Kimi integration for Kimi Code CLI#2979
Open
meymchen wants to merge 4 commits into
Open
feat(integration): update Kimi integration for Kimi Code CLI#2979meymchen wants to merge 4 commits into
meymchen wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the built-in kimi integration to match Moonshot AI’s newer Kimi Code CLI project layout, including new install locations, legacy migration behavior, and devcontainer installation instructions.
Changes:
- Move Kimi skills install path from
.kimi/skills/to.kimi-code/skills/and switch the context file fromKIMI.mdtoAGENTS.md. - Expand
--migrate-legacyto migrate old skill installs and migrate user-authored content fromKIMI.md→AGENTS.md. - Update docs, changelog, devcontainer installer, and tests to reflect the new Kimi Code CLI integration behavior.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/kimi/__init__.py |
Updates Kimi integration paths, adds migration + legacy cleanup logic, and changes multi-install safety. |
tests/integrations/test_integration_kimi.py |
Updates Kimi integration expectations and adds tests for legacy skills dir + context migration and teardown cleanup. |
tests/integrations/test_integration_subcommand.py |
Adjusts integration switch test expectations for Kimi’s new skills directory. |
tests/test_presets.py |
Updates preset-related tests to use the new Kimi skills directory location. |
tests/test_extensions.py |
Updates parametrized “skill agents” test cases to use .kimi-code/skills. |
tests/test_agent_config_consistency.py |
Ensures runtime and registrar configs match the new .kimi-code/ folder layout. |
docs/reference/integrations.md |
Documents new Kimi paths and expanded --migrate-legacy behavior. |
CHANGELOG.md |
Adds a changelog entry describing the Kimi Code CLI integration update. |
.devcontainer/post-create.sh |
Switches Kimi installation from pipx install kimi-cli to npm install -g @moonshot-ai/kimi-code@latest. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 4
Collaborator
|
Please address Copilot feedback |
Update the Kimi integration to target the new Kimi Code CLI (MoonshotAI/kimi-code) layout: - Change skills directory from .kimi/skills/ to .kimi-code/skills/ - Change context file from KIMI.md to AGENTS.md - Extend --migrate-legacy to move old .kimi/skills/ installs and migrate KIMI.md user content to AGENTS.md - Clean up leftover legacy .kimi/skills/ directories on teardown - Update devcontainer installer to @moonshot-ai/kimi-code - Update docs and tests Relates to github#1532
- Override build_command_invocation to emit /skill:speckit-<stem> so dispatched commands match Kimi Code CLI's native slash syntax. - Skip symlinked .kimi/skills directories during legacy migration and teardown to avoid operating on files outside the project. - Remove kimi from the multi-install-safe integrations table. - Add tests for command invocation and symlink safety.
meymchen
force-pushed
the
feat/1532-kimi-code-cli-compatibility
branch
from
65d3f30 to
a5dc347
Compare
Author
|
@mnriem All Copilot feedback has been addressed in the latest commit ( Changes made:
I also resolved the Copilot review threads. Let me know if anything else needs adjustment. |
Collaborator
|
Please address Copilot feedback |
…-cli-compatibility
…tion Use IntegrationBase._resolve_context_markers() when migrating legacy KIMI.md content so that projects with customized context_markers in .specify/extensions/agent-context/agent-context-config.yml have the managed section stripped with the correct markers instead of the hard-coded defaults. Adds a test verifying custom markers are respected during --migrate-legacy.
Author
|
Posted on behalf of @meymchen by Kimi Code CLI agent. Latest Copilot feedback has been addressed in commit
Per project convention, I am leaving the review conversations for the reviewer/PR author to resolve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the built-in Kimi integration to align with the new Kimi Code CLI layout from Moonshot AI.
Relates to #1532.
Changes
.kimi/skills/to.kimi-code/skills/KIMI.mdtoAGENTS.md--migrate-legacynow also migrates:.kimi/skills/installs to.kimi-code/skills/speckit.xxx) to hyphenated (speckit-xxx)KIMI.mdtoAGENTS.mdteardown()removes leftover Speckit-generated.kimi/skills/speckit-*directoriesmulti_install_safeset toFalsebecause Kimi now sharesAGENTS.mdwith Codexpipx install kimi-clitonpm install -g @moonshot-ai/kimi-code@latestdocs/reference/integrations.md,CHANGELOG.md, and testsTesting
uv run pytest tests/integrations/test_integration_kimi.py— 43 passeduv run pytest tests/integrations/— 2218 passeduv run pytest tests/ -k kimi— 57 passedAI Assistance Disclosure
This change was developed with AI assistance for codebase exploration, implementation planning, and test generation. The final design decisions, code review, and verification were done by a human contributor.