fix(goose): declare args parameter in generated recipes#2402
Open
natelastname wants to merge 2 commits intogithub:mainfrom
Open
fix(goose): declare args parameter in generated recipes#2402natelastname wants to merge 2 commits intogithub:mainfrom
natelastname wants to merge 2 commits intogithub:mainfrom
Conversation
mnriem
requested changes
Apr 29, 2026
Collaborator
mnriem
left a comment
mnriem
left a comment
There was a problem hiding this comment.
Can you add some positive and negative tests?
Author
Sure, please let me know if there's anything else I can do. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Goose YAML recipe generation so recipes that include {{args}} also declare an args parameter, preventing goose recipe validate failures.
Changes:
- Override
GooseIntegration._render_yamlto emit aparameterssection declaringargs. - Add integration tests asserting generated Goose recipes declare
argswhen{{args}}appears in the prompt. - Add a control test confirming the base
YamlIntegrationrenderer does not declareparameters.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/goose/__init__.py |
Adds Goose-specific YAML rendering that includes an args parameter definition. |
tests/integrations/test_integration_goose.py |
Adds tests verifying the new Goose renderer behavior and documenting the base renderer behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
+3
to
+4
| import re | ||
|
|
Collaborator
|
Please address Copilot feedback |
natelastname
force-pushed
the
fix/goose-args-parameter
branch
from
87641b3 to
5cbe958
Compare
Author
I just edited my previous commit to remove the unused import. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Goose integration YAML recipe generation so recipes that reference {{args}} declare a corresponding args parameter, preventing goose recipe validate failures.
Changes:
- Override
GooseIntegration._render_yamlto emit aparameterssection containing anargsparameter. - Add Goose-specific tests to ensure generated recipes that contain
{{args}}include anargsparameter declaration.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/goose/__init__.py |
Overrides YAML rendering to include an args parameter in the recipe header. |
tests/integrations/test_integration_goose.py |
Adds regression tests for args parameter declaration behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 3
Comment on lines
+39
to
+51
| def test_base_yaml_renderer_does_not_declare_args_parameter(self): | ||
| # “Without the Goose-specific override, recipes using {{args}} do NOT declare it.” | ||
| rendered = YamlIntegration._render_yaml( | ||
| "Test", | ||
| "Test recipe", | ||
| "{{args}}", | ||
| "templates/commands/test.md", | ||
| ) | ||
|
|
||
| data = yaml.safe_load(rendered) | ||
|
|
||
| assert "{{args}}" in data["prompt"] | ||
| assert "parameters" not in data |
|
|
||
| def test_setup_declares_args_parameter_for_args_prompt(self, tmp_path): | ||
| # “If a Goose recipe uses {{args}}, it correctly declares the args parameter.” | ||
| integration = get_integration("goose") |
Comment on lines
+25
to
+35
| @staticmethod | ||
| def _render_yaml(title: str, description: str, body: str, source_id: str) -> str: | ||
| """Render a Goose YAML recipe with the required args parameter.""" | ||
|
|
||
| header = { | ||
| "version": "1.0.0", | ||
| "title": title, | ||
| "description": description, | ||
| "author": {"contact": "spec-kit"}, | ||
| "extensions": [{"type": "builtin", "name": "developer"}], | ||
| "activities": ["Spec-Driven Development"], |
Collaborator
|
Please address Copilot feedback. If not applicable, please explain why |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in the Goose integration where generated recipes include
{{args}}in the prompt but do not declare a correspondingargsparameter.This causes
goose recipe validateto fail with:The fix overrides
_render_yamlinGooseIntegrationto include aparameterssection declaring theargsparameter, ensuring all generated recipes are valid.Testing
uv run specify --helpuv sync --extra test && uv run pytestgoose recipe validate)AI Disclosure
Consulted ChatGPT to reason through the root cause and propose an implementation approach. Final code and validation were done manually.