Skip to content

fix(scripts): encode residual JSON control chars as \uXXXX instead of stripping #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pierluigilenoci wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −3
Open

fix(scripts): encode residual JSON control chars as \uXXXX instead of stripping #1872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions scripts/bash/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,21 @@ json_escape() {
s="${s//$'\r'/\\r}"
s="${s//$'\b'/\\b}"
s="${s//$'\f'/\\f}"
# Strip remaining control characters (U+0000–U+001F) not individually escaped above
s=$(printf '%s' "$s" | tr -d '\000-\007\013\016-\037')
printf '%s' "$s"
# Escape any remaining U+0000-U+001F control characters as \uXXXX.
# Only single-byte characters can be JSON control chars; multi-byte UTF-8
# sequences have first-byte values >= 0xC0 and are never control characters.
local i char code
local out=""
for (( i=0; i<${#s}; i++ )); do
char="${s:$i:1}"
code=$(LC_ALL=C printf '%d' "'$char" 2>/dev/null || echo 256)
if (( code >= 0 && code <= 31 )); then
out+=$(printf '\\u%04x' "$code")
else
out+="$char"
fi
done
printf '%s' "$out"
}

check_file() { [[ -f "$1" ]] && echo " ✓ $2" || echo " ✗ $2"; }
Expand Down