Claude/test coverage analysis s33ri0#2733
Open
israel2606 wants to merge 5 commits into
Open
Conversation
…pers Raise cmd/mcpcurl coverage from ~9% to ~55% by testing the pure-logic helpers, in a separate file from the existing main_test.go: - buildArgumentsMap: all property types (string/number/integer/boolean, string arrays, object arrays via -json) plus the JSON-parse error path. - addCommandFromTool: flag registration, required flags, and enum PreRunE validation. - buildJSONRPCRequest: request envelope shape. - printResponse: plain, pretty-object, JSONL-array, empty, and invalid-JSON. https://claude.ai/code/session_01W9xh1kJCqtHqBgBAMQikon
Recover docs/erp-grupo-tesela/ARQUITECTURA.md (lost from main in the upstream reset; restored from commit e8cd954) and correct it per the design review: - Automations (Make/Zapier) now go through the API/Edge Functions instead of writing directly to Postgres, preserving the single-source-of-truth. - Re-prioritize phases for the construction/architecture/real-estate- development sector: Works/Projects and property sales become the core. - Add Spanish tax handling (reverse-charge VAT, SII/Verifactu, certificaciones), a build-vs-buy decision for the accounting core (Holded/Odoo/Presto), an initial data model, security/RGPD/backups, and per-phase KPIs. - Trim overlap (Make+Zapier, Airtable+Notion+Supabase), move Supermetrics to a later phase, replace generic inventory with per-work procurement, and flag that Coupler.io has no MCP connector here. https://claude.ai/code/session_01W9xh1kJCqtHqBgBAMQikon
Per the cross-session coordination note (Drive), reconcile the ERP architecture with operational reality: - Holded is LIVE and the canonical source of finance/accounting; it is no longer a pending build-vs-buy decision. Supabase stays as the bespoke operational layer and must not become a second ledger. - Record the single cost/margin rules: cost by Holded projectid (not tags), exclude confirming, own labor = direct cost, one margin calculation; reference validation against the Palmeres work. - One canonical Holded integration (direct API); any Make/Zapier bridge is automation-only, never a second source of truth. - Note governance (Drive = memory, Cerebro repo = code) and the pending key rotation for previously-exposed Holded credentials. https://claude.ai/code/session_01W9xh1kJCqtHqBgBAMQikon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Fixes #
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs