Promote issue fields and deprecate legacy issue write tool #2696
Open
reneexeener wants to merge 18 commits into
Open
Promote issue fields and deprecate legacy issue write tool #2696reneexeener wants to merge 18 commits into
reneexeener wants to merge 18 commits into
Conversation
boazreicher
reviewed
Jun 17, 2026
boazreicher
previously approved these changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the remote_mcp_issue_fields feature flag so Issues 2.0 custom fields support (listing fields, filtering by fields, and enriching issue results with field_values) is available by default, and it deletes the legacy tool variants that existed only for the flag-off behavior.
Changes:
- Removed the
remote_mcp_issue_fieldsfeature flag and legacylist_issues/issue_writevariants that depended on it. - Promoted issue fields support into the default tool schemas (
issue_fieldsonissue_write,field_filtersonlist_issues) and updated tool snapshots accordingly. - Updated documentation and tests to reflect the always-on issue fields behavior.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents list_issue_fields and the now-default issue_fields / field_filters parameters. |
| pkg/github/ui_tools.go | Makes UI issue-fields retrieval unconditional (no feature-flag gate). |
| pkg/github/ui_tools_test.go | Updates UI tool tests to validate successful issue-fields fetch. |
| pkg/github/tools.go | Removes registration of legacy issue tools from the full tool list. |
| pkg/github/minimal_types.go | Deletes legacy minimal conversion helpers used by the flag-off list_issues variant. |
| pkg/github/issues.go | Removes legacy GraphQL types and tool variants; always supports field filters/enrichment. |
| pkg/github/issues_test.go | Updates tests and toolsnap assertions to match the default (always-on) issue fields behavior. |
| pkg/github/issue_fields.go | Un-gates list_issue_fields so it’s always registered. |
| pkg/github/feature_flags.go | Deletes the remote_mcp_issue_fields flag constant and removes it from allowed/insiders lists. |
| pkg/github/csv_output_test.go | Switches the CSV gating test to use FeatureFlagFileBlame after flag removal. |
| pkg/github/toolsnaps/list_issues.snap | Adds field_filters to the default list_issues schema snapshot. |
| pkg/github/toolsnaps/list_issues_ff_remote_mcp_issue_fields.snap | Removes the flag-specific list_issues snapshot. |
| pkg/github/toolsnaps/issue_write.snap | Adds issue_fields to the default issue_write schema snapshot. |
| pkg/github/toolsnaps/issue_write_ff_remote_mcp_issue_fields.snap | Removes the flag-specific issue_write snapshot. |
| docs/insiders-features.md | Removes remote_mcp_issue_fields section; documents issue fields as default. |
| docs/feature-flags.md | Removes remote_mcp_issue_fields section; documents issue fields as default. |
Copilot's findings
- Files reviewed: 16/16 changed files
- Comments generated: 0
lukewar
previously approved these changes
Jun 18, 2026
lukewar
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
remote_mcp_issue_fieldsfeature flag, making issue fields and related functionality (e.g.field_filterssupport in issue tools) available by default, and updates documentation and tests to reflect this change.Why
What changed
FeatureFlagIssueFields(remote_mcp_issue_fields) feature flag and its usage from the codebase and allowed flags list.pkg/github/feature_flags.go[1] [2]remote_mcp_issue_fieldsand always document issue field support in issue tools.docs/feature-flags.md[1] [2]docs/insiders-features.md[3] [4]*_ff_remote_mcp_issue_fields.snap).pkg/github/__toolsnaps__/issue_write_ff_remote_mcp_issue_fields.snap[1]pkg/github/__toolsnaps__/list_issues_ff_remote_mcp_issue_fields.snap[2]issue_fieldsandfield_filtersparameters to the default tool schemas and documentation.README.md[1] [2] [3]pkg/github/__toolsnaps__/issue_write.snap[4]pkg/github/__toolsnaps__/list_issues.snap[5]FeatureFlagFileBlame) for CSV output gating, reflecting the removal.pkg/github/csv_output_test.goThese changes streamline the codebase by making issue field support a standard feature, reducing complexity and improving documentation clarity.
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs