Spike: instruction resolver with most-specificity rule#1867
Draft
SamMorrowDrums wants to merge 1 commit intomainfrom
Draft
Spike: instruction resolver with most-specificity rule#1867SamMorrowDrums wants to merge 1 commit intomainfrom
SamMorrowDrums wants to merge 1 commit intomainfrom
Conversation
Add InstructionRule and InstructionResolver types that enable associating instructions with specific sets of tools rather than whole toolsets. Key features: - Rules match when ALL specified tools are present in active tools - Most-specific rule wins: superset rules shadow subset rules - Partial overlaps (neither superset) result in both rules applying - Deterministic output via sorted results This is exploratory work to evaluate finer-grained instruction control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exploratory spike to evaluate finer-grained instruction control by associating instructions with specific sets of tools rather than whole toolsets.
Design
Core Types
InstructionRule- Associates an instruction with a set of tool namesInstructionResolver- Resolves which instructions apply using the most-specificity ruleSpecificity Algorithm
Example
Testing
All tests pass:
TestInstructionResolver_BasicMatchingTestInstructionResolver_SupersetShadowingTestInstructionResolver_PartialOverlapNoShadowingTestInstructionResolver_ComplexHierarchyTestInstructionResolver_EmptyRulesTestInstructionResolver_EmptyActiveToolsNext Steps (if we proceed)
GenerateInstructions()or create a V2