Draft
Improve ExtractWorkflowNameFromFile hot-path parsing to recover benchmark regression#45225
ExtractWorkflowNameFromFile hot-path parsing to recover benchmark regression#45225Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix performance regression in ExtractWorkflowNameFromFile
Improve Jul 13, 2026
ExtractWorkflowNameFromFile hot-path parsing to recover benchmark regression
Contributor
|
Thanks for documenting the benchmark regression and the intended parser optimization clearly. The core change is on-topic, but this PR is not focused yet because it also updates a very large set of Please split this into a narrowly scoped PR that contains only the parser/test changes, or clearly justify why the lockfile churn is required for this change.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BenchmarkExtractWorkflowNameFromFileregressed materially versus historical baseline despite low allocations. This change reduces per-line parsing overhead in the workflow title scanner while preserving existing parsing behavior for whitespace-tolerant markdown/frontmatter inputs.Parser hot path simplification
fastParseTitleFromReaderto check raw scanned bytes first for:---)TrimSpace/prefix work on every line.Behavior-preserving helper extraction
isFrontmatterDelimiter([]byte)extractHeadingTitle([]byte) (string, bool)Edge-case coverage for whitespace-tolerant parsing