Add engine.extensions to workflow schema and generated frontmatter docs#42317
Closed
Copilot wants to merge 5 commits into
Closed
Add engine.extensions to workflow schema and generated frontmatter docs#42317Copilot wants to merge 5 commits into
engine.extensions to workflow schema and generated frontmatter docs#42317Copilot wants to merge 5 commits into
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add engine.extensions to main_workflow_schema.json
Add Jun 29, 2026
engine.extensions to workflow schema and generated frontmatter docs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to add support for engine.extensions to the main workflow JSON schema and ensure the generated frontmatter reference includes it, with regression coverage in both Go schema validation tests and the schema-doc generator tests.
Changes:
- Adds
engine.extensionstopkg/parser/schemas/main_workflow_schema.json. - Adds schema validation coverage for
engine.extensionsinpkg/parser/schema_test.go. - Extends schema-doc generator tests and updates the generated frontmatter reference output.
Show a summary per file
| File | Description |
|---|---|
| scripts/generate-schema-docs.test.js | Adds assertions that engine.extensions appears in generated docs (but currently asserts incorrect semantics). |
| pkg/parser/schemas/main_workflow_schema.json | Introduces engine.extensions schema property (but description/examples conflict with existing Pi extension/plugin behavior). |
| pkg/parser/schema_test.go | Adds schema validation test for engine.extensions (but uses values that don’t match how Pi extensions are implemented). |
| docs/src/content/docs/reference/frontmatter-full.md | Updates generated frontmatter reference to include engine.extensions (but wording reflects incorrect semantics). |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 5
- Review effort level: Low
Comment on lines
+12056
to
+12066
| "extensions": { | ||
| "type": "array", | ||
| "description": "Optional allowlist of file extensions that the Pi engine may modify. Entries should be strings such as '.go' or '.md'. When omitted or empty, the Pi engine uses its default extension behavior.", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "examples": [ | ||
| [".go", ".md"], | ||
| [".js", ".ts", ".json"] | ||
| ] | ||
| }, |
Comment on lines
+2288
to
+2290
| # Optional allowlist of file extensions that the Pi engine may modify. Entries | ||
| # should be strings such as '.go' or '.md'. When omitted or empty, the Pi engine | ||
| # uses its default extension behavior. |
Comment on lines
+483
to
+486
| "engine": map[string]any{ | ||
| "id": "pi", | ||
| "extensions": []any{".go", ".md"}, | ||
| }, |
Comment on lines
+496
to
+499
| "engine": map[string]any{ | ||
| "id": "pi", | ||
| "extensions": []any{".go", 1}, | ||
| }, |
Comment on lines
+102
to
+104
| // Test 8: Verify engine.extensions appears in generated docs | ||
| allPassed &= assertContains(output, "extensions:", "Engine extensions field should be present in generated docs"); | ||
| allPassed &= assertContains(output, "Pi engine may modify", "Engine extensions description should be present in generated docs"); |
Contributor
🔍 PR Triage — §28395315609
Score breakdown: impact 22 + urgency 14 + quality 15
|
Collaborator
|
@copilot All CI checks are passing and the branch is clean. Please address the open inline feedback from the automated Copilot code review before this PR can merge. Unresolved feedback from
Once those are addressed, please invoke the
|
Copilot stopped work on behalf of
gh-aw-bot due to an error
June 29, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi workflows already support
engine.extensionsat parse/runtime, but the field was missing from the main workflow schema. That caused valid workflows to fail schema validation and left the generated frontmatter reference incomplete.Schema
engine.extensionsto$defs.engine_config.propertiesinpkg/parser/schemas/main_workflow_schema.jsonarray<string>with Pi-specific semantics and examplesRegression coverage
engine.extensionsmust appear in generated outputGenerated reference
docs/src/content/docs/reference/frontmatter-full.mdto include the missingengine.extensionssection in the engine config reference