Conversation
Add Conclusion Filtering subsection to the Workflow Run Triggers section, mirroring the existing deployment_status.state documentation. The on.workflow_run.conclusion field (added in #29089) compiles into a guarded if: condition at build time, allowing users to filter workflow runs by their conclusion without writing the two-part GitHub Actions expression guard manually. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
automation
documentation
Collaborator
|
@copilot unbloat changes |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing reference documentation for the newly supported on.workflow_run.conclusion frontmatter filter.
Changes:
- Documented
workflow_run.conclusionsyntax for single and multiple values. - Listed valid conclusion values and explained how the compiler implements the filter via a guarded
if:condition.
Show a summary per file
| File | Description |
|---|---|
| docs/src/content/docs/reference/triggers.md | Adds a workflow_run subsection documenting the new conclusion: filter and its compiled behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
|
|
||
| #### Conclusion Filtering (`conclusion:`) | ||
|
|
||
| Use `conclusion:` to restrict the trigger to specific workflow run outcomes. The compiler compiles this into a guarded `if:` condition so the workflow only runs for the matching conclusions. Other combined triggers (such as `workflow_dispatch`) are not blocked by the guard. |
There was a problem hiding this comment.
The wording here implies conclusion: filters the trigger ("restrict the trigger" / "workflow only runs"), but GitHub Actions can’t filter workflow_run at the event level; this feature is implemented by compiling conclusion: into an if: on the activation job. As a result, a run may still be created and then skipped when the conclusion doesn’t match. Consider rephrasing to explicitly say the compiler injects a guarded activation-job if: that skips execution unless the conclusion matches (while remaining a no-op for other events).
Suggested change
| Use `conclusion:` to restrict the trigger to specific workflow run outcomes. The compiler compiles this into a guarded `if:` condition so the workflow only runs for the matching conclusions. Other combined triggers (such as `workflow_dispatch`) are not blocked by the guard. | |
| For `workflow_run`, use `conclusion:` to have the compiler inject a guarded `if:` on the activation job for specific workflow run outcomes. This does not filter the GitHub Actions event itself: a workflow run may still be created and then skipped when the conclusion does not match. Other combined triggers (such as `workflow_dispatch`) are not blocked by the guard. |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/3c1adbce-ef78-46bf-88b4-f16303d22c31 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
pelikhan
deleted the
docs/healer-workflow-run-conclusion-2026-04-30-043d180a406f24c6
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-Healing Documentation Fixes
This PR was automatically created by the Daily Documentation Healer workflow.
Gaps Fixed
on.workflow_run.conclusionfiltering —docs/src/content/docs/reference/triggers.mdhad aworkflow_run:section covering security protections and branch restrictions, but lacked the newconclusion:filter field added in feat: add on.workflow_run.conclusion filter support #29089 (merged 2026-04-29 13:21 UTC). Added a#### Conclusion Filtering (\conclusion:`)subsection documenting single/multi-value usage, valid values, and how the compiler translates the field into a guardedif:` condition.Root Cause
DDUw ran on 2026-04-29 at 11:18 UTC (PR #29083). Commit #29089 landed at 13:21 UTC — after that run. Today's DDUw run (PR #29288) documented
--stdinfrom #29170 but missed theworkflow_run.conclusionfeature from #29089, which was also in its 24-hour window. The feature name ("compile filter intoifcondition") did not match the pattern DDUw typically scans for ("new flag" or "new frontmatter field"), and the ADR-style commit message obscured its user-facing nature.💡 DDUw Improvement Suggestions
DDUw Improvement Suggestions
Problem: DDUw skipped
on.workflow_run.conclusioneven though it fell within the 24-hour window.Root cause: The commit message was
feat: add on.workflow_run.conclusion filter support— a clear user-facing feature — but today's DDUw PR (#29288) documented only--stdinwith no mention ofworkflow_run.conclusion. DDUw likely evaluated the commit's changed files (pkg/workflow/frontmatter_extraction_yaml.go,.github/aw/create-agentic-workflow.md, an ADR file) and concluded the feature was internal or already covered by the ADR.Suggested Step 2 heuristic addition in
.github/workflows/daily-doc-updater.md:Related Issues
References: