Conversation
…nt bash history expansion Agent-Logs-Url: https://github.com/github/gh-aw/sessions/55a4df31-63b1-4b54-ad7e-728dd91799b4 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Issue Monster comment template to avoid !-triggered bash history expansion leaking shell markers into add_comment bodies.
Changes:
- Removes the
!afterCopilotin thesafeoutputs/add_commenttemplate body.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/issue-monster.md | Adjusts the Issue Monster add_comment body template to mitigate bash history expansion issues. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
|
|
||
| ``` | ||
| safeoutputs/add_comment(item_number=<issue_number>, body="🍪 **Issue Monster selected this for Copilot!**\n\nI've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.\n\nIf assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.\n\nOm nom nom! 🍪") | ||
| safeoutputs/add_comment(item_number=<issue_number>, body="🍪 **Issue Monster selected this for Copilot**\n\nI've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.\n\nIf assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.\n\nOm nom nom! 🍪") |
There was a problem hiding this comment.
The comment template still contains an exclamation mark in the body string ("Om nom nom! 🍪"). In an interactive bash session with history expansion enabled, any ! inside double quotes can be expanded or cause an event not found error, which can still leak or break the generated add_comment call. To fully address the reported issue, remove or escape this remaining ! (and keep the template free of ! characters, or ensure history expansion is disabled where this snippet is executed).
| safeoutputs/add_comment(item_number=<issue_number>, body="🍪 **Issue Monster selected this for Copilot**\n\nI've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.\n\nIf assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.\n\nOm nom nom! 🍪") | |
| safeoutputs/add_comment(item_number=<issue_number>, body="🍪 **Issue Monster selected this for Copilot**\n\nI've identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.\n\nIf assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.\n\nOm nom nom 🍪") |
The
!in"🍪 **Issue Monster selected this for Copilot!**"triggered bash history expansion (!*→ previous command's arguments) inside Copilot CLI's bash session, leaking internal init markers (___BEGIN___COMMAND_OUTPUT_MARKER___,PS1=,unset HISTFILE, etc.) into theadd_commentbody.Change
.github/workflows/issue-monster.md:Copilot!**→Copilot**in the comment template