fix: use DeletionHandlingMetaNamespaceKeyFunc in DeleteFunc for tombstone support#70
Merged
bdehamer merged 2 commits intobdehamer/refactor-controller-splitfrom Mar 23, 2026
Merged
Conversation
…tone support Co-authored-by: bdehamer <398027+bdehamer@users.noreply.github.com> Agent-Logs-Url: https://github.com/github/deployment-tracker/sessions/620a8570-c815-4b5f-95cd-25d107fcd82a
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Refactor: Apply feedback on splitting controller.go into focused files
fix: use DeletionHandlingMetaNamespaceKeyFunc in DeleteFunc for tombstone support
Mar 23, 2026
bdehamer
approved these changes
Mar 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Kubernetes informer delete-event handling by ensuring keys are generated correctly even when the delete event arrives as a tombstone (cache.DeletedFinalStateUnknown), preventing delete events from being dropped during resync/missed-watch scenarios.
Changes:
- Switch
DeleteFunckey generation fromcache.MetaNamespaceKeyFunctocache.DeletionHandlingMetaNamespaceKeyFuncto properly handle tombstones.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeleteFuncwas callingcache.MetaNamespaceKeyFunc(obj)after tombstone extraction, but whenobjis acache.DeletedFinalStateUnknown, this call errors and the delete event is silently dropped — a common case when the informer misses a delete during a resync.Change
Replace with
cache.DeletionHandlingMetaNamespaceKeyFunc(obj), which unwraps tombstones internally before computing the key:This ensures delete events are reliably enqueued regardless of whether
objis a live object or a tombstone.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.