Bump node from 20 to 24#1688
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the action runtime from Node 20 (EOL April 2026) to Node 24, updates .nvmrc to 24.13.0, and increases the container-service test beforeAll timeout to 30s to accommodate the real docker pull alpine performed in the hook.
Changes:
- Switch action runtime to
node24inaction.yml. - Update
.nvmrcto24.13.0. - Increase
beforeAlltimeout incontainer-service.test.tsto 30000ms.
Show a summary per file
| File | Description |
|---|---|
| action.yml | Updates runtime declaration from node20 to node24. |
| .nvmrc | Pins local Node version to 24.13.0. |
| tests/container-service.test.ts | Extends beforeAll timeout to 30s for the docker pull. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 0
truggeri
approved these changes
May 14, 2026
Nishnha
force-pushed
the
nishnha/bump-node-24
branch
from
edb7aa4 to
b6278b8
Compare
Node 20 is EOL (April 2026). Bumps the action runtime to node24 and .nvmrc to 24.13.0, matching upstream LTS. Also bumps the container-service beforeAll timeout from the default 5s to 30s — the hook does a real docker pull alpine and was racing the timeout on cold caches. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Nishnha
force-pushed
the
nishnha/bump-node-24
branch
from
b6278b8 to
9abb07b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 20 is EOL (April 2026). Bumps the action runtime to
node24and.nvmrcto 24.13.0.Picks up where #1677 left off (that PR is from a fork and we couldn't push to it).
Also bumps the
container-servicebeforeAlltimeout from the default 5s to 30s — the hook does a realdocker pull alpineand was racing the timeout on cold runner caches. The previousjest.setTimeout(5000)calls inside the innerdescribeblocks don't apply to the outerbeforeAll.