Update import statement for PermissionHandler#950
Update import statement for PermissionHandler#950rrachedEnterprise wants to merge 1 commit intogithub:mainfrom
Conversation
the example uses an outdated SDK API. Fixed PermissionHandler import.
There was a problem hiding this comment.
Pull request overview
Updates the Python “getting started” documentation snippet to use a new import path for PermissionHandler, aiming to reflect the current Python SDK API.
Changes:
- Modified the Python quickstart example import for
PermissionHandlerin the getting-started guide.
| import asyncio | ||
| from copilot import CopilotClient | ||
| from copilot.session import PermissionHandler | ||
| from copilot.types import PermissionHandler |
There was a problem hiding this comment.
copilot.types does not appear to exist in the Python package in this repo (PermissionHandler is defined in copilot.session). As written, this getting-started example will raise ModuleNotFoundError: No module named 'copilot.types'. Update the import back to from copilot.session import PermissionHandler (or add/re-export a copilot.types module if that’s the intended new public API) and keep the other Python snippets in this doc consistent.
| from copilot.types import PermissionHandler | |
| from copilot.session import PermissionHandler |
There was a problem hiding this comment.
ok - but the current github-copilot-sdk (github-copilot-sdk 0.2.0) places PermissionHandler inside copilot.types. And github-copilot-sdk 0.2.0 is the version a user would get when following the tutorial. (agreed that we woudl also need to change all other imports in the tutorial for consistency).
the example uses an outdated SDK API.
Fixed PermissionHandler import.