Skip to content

Disable overlay status check for CS config test workflow#3535

Merged
mbg merged 3 commits intomainfrom
mbg/ci/no-skip-overlay
Mar 3, 2026
Merged

Disable overlay status check for CS config test workflow#3535
mbg merged 3 commits intomainfrom
mbg/ci/no-skip-overlay

Conversation

@mbg
Copy link
Member

@mbg mbg commented Mar 3, 2026

This workflow is currently failing, because #3487 is enabled for this repo and a build on main failed. We can delete the cache to unblock the workflow, but would then have the same problem next time a CodeQL analysis fails on main.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

N/A

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@mbg mbg requested a review from a team as a code owner March 3, 2026 11:55
Copilot AI review requested due to automatic review settings March 3, 2026 11:55
@mbg mbg self-assigned this Mar 3, 2026
@github-actions github-actions bot added the size/XS Should be very easy to review label Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the OverlayAnalysisStatusCheck feature flag for the Code Scanning config CLI test workflow. PR #3487 introduced caching of overlay analysis failures, which caused this test workflow to skip overlay analysis when a main-branch build had previously failed. Setting CODEQL_ACTION_OVERLAY_ANALYSIS_STATUS_CHECK: false prevents the cached failure status from affecting this test workflow, ensuring stable test results independent of transient main-branch build failures.

Changes:

  • Adds CODEQL_ACTION_OVERLAY_ANALYSIS_STATUS_CHECK: false as a workflow-level env var to disable the overlay status check feature for the CS config test workflow.

@mbg mbg force-pushed the mbg/ci/no-skip-overlay branch from f891370 to 1175fd9 Compare March 3, 2026 12:06
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and good idea re adding JSDoc to Features

@mbg mbg enabled auto-merge March 3, 2026 12:10
@mbg mbg added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 40f0fa9 Mar 3, 2026
244 checks passed
@mbg mbg deleted the mbg/ci/no-skip-overlay branch March 3, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants