Skip to content

[GHSA-q9hv-hpm4-hj6x] CIRCL has an incorrect calculation in secp384r1 CombinedMult#7173

Open
yusuke-koyoshi wants to merge 1 commit intoyusuke-koyoshi/advisory-improvement-7173from
yusuke-koyoshi-GHSA-q9hv-hpm4-hj6x
Open

[GHSA-q9hv-hpm4-hj6x] CIRCL has an incorrect calculation in secp384r1 CombinedMult#7173
yusuke-koyoshi wants to merge 1 commit intoyusuke-koyoshi/advisory-improvement-7173from
yusuke-koyoshi-GHSA-q9hv-hpm4-hj6x

Conversation

@yusuke-koyoshi
Copy link

Updates

  • CVSS v4
  • Severity

Comments
Current vector:
CVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:N/VC:L/VI:L/VA:L/SC:L/SI:L/SA:L/E:P/S:N/AU:Y/U:Amber Score: 2.9 (LOW)
Proposed vector:
CVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:N/VC:L/VI:L/VA:N/SC:N/SI:N/SA:N/S:N/AU:Y/U:Amber Score: 6.3 (MEDIUM)

Removal of E:P (Exploit Maturity): Threat Metrics are intended to reflect the current threat landscape and require continuous updates. As GHSA does not maintain an ongoing update process for Threat Metrics, including a static E:P value artificially suppresses the score and may mislead consumers. Since Threat Metrics can only lower the Base score, an outdated value is more harmful than omitting it.

VA:L → VA:N: The advisory does not describe any availability impact. The incorrect calculation in CombinedMult does not cause a denial-of-service condition, so VA:L is not justified.

SC/SI/SA:L → SC/SI/SA:N: The advisory explicitly states "ECDH and ECDSA signing relying on this curve are not affected." There is no demonstrated impact on subsequent systems, making SC/SI/SA:N the appropriate value.

The "Suggest improvements" form on GitHub does not support input of Supplemental Metrics. However, the current advisory includes S:N/AU:Y/U:Amber, and since Supplemental Metrics have no effect on the CVSS score, we recommend retaining these values as-is when applying the proposed changes. The intended final vector, including Supplemental Metrics, is:
CVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:N/VC:L/VI:L/VA:N/SC:N/SI:N/SA:N/S:N/AU:Y/U:Amber

@github
Copy link
Collaborator

github commented Mar 15, 2026

Hi there @mschwarzl! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Copilot AI review requested due to automatic review settings March 15, 2026 04:59
@github-actions github-actions bot changed the base branch from main to yusuke-koyoshi/advisory-improvement-7173 March 15, 2026 05:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GHSA advisory metadata to reflect an updated CVSS v4 vector and severity for the CIRCL secp384r1 CombinedMult calculation issue.

Changes:

  • Updated the advisory modified timestamp.
  • Updated the CVSS v4 vector in severity[].score.
  • Raised overall advisory severity from LOW to MODERATE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 13 to 15
"type": "CVSS_V4",
"score": "CVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:N/VC:L/VI:L/VA:L/SC:L/SI:L/SA:L/E:P/S:N/AU:Y/U:Amber"
"score": "CVSS:4.0/AV:N/AC:H/AT:N/PR:N/UI:N/VC:L/VI:L/VA:N/SC:N/SI:N/SA:N"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants