feat: support per-runner-flavor SQS batch size and window in multi_runner_config#5108
Draft
feat: support per-runner-flavor SQS batch size and window in multi_runner_config#5108
Conversation
…nner_config Add lambda_event_source_mapping_batch_size and lambda_event_source_mapping_maximum_batching_window_in_seconds as optional fields inside multi_runner_config.runner_config, falling back to the existing module-level variables when not set via coalesce(). This follows the same pattern used by scale_up_reserved_concurrent_executions. Agent-Logs-Url: https://github.com/github-aws-runners/terraform-aws-github-runner/sessions/1a1b641a-bbf5-45ab-bd97-73d9501552b9 Co-authored-by: Brend-Smits <15904543+Brend-Smits@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support per-runner-flavor SQS batch size and window configuration
feat: support per-runner-flavor SQS batch size and window in multi_runner_config
Apr 14, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
lambda_event_source_mapping_batch_sizeandlambda_event_source_mapping_maximum_batching_window_in_secondsare module-level variables applied identically to every runner flavor. Deployments with mixed load profiles (e.g. 1000-runner high-volume vs 10-runner low-volume) need per-flavor tuning to avoid unnecessary latency, wasted SSM throughput, and GitHub API rate limit pressure on low-volume flavors.Adds both as
optional(number, null)fields inmulti_runner_config.runner_config, withcoalesce()fallback to the existing module-level variables. Follows the established pattern used byscale_up_reserved_concurrent_executions.Changes:
modules/multi-runner/variables.tf— new optional fields in therunner_configobject type + descriptionsmodules/multi-runner/runners.tf—coalesce(per_flavor, module_level)for both parametersUsage:
Fully backwards compatible. Existing configs require no changes.
Test Plan
terraform fmt(clean)enable_jit_configdescription in the heredoc — not introduced by this PR)Related Issues
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
checkpoint-api.hashicorp.com/usr/local/bin/terraform terraform version(dns block)/usr/local/bin/terraform terraform fmt modules/multi-REDACTED/variables.tf modules/multi-REDACTED/REDACTEDs.tf(dns block)If you need me to access, download, or install something from one of these locations, you can either: