Add Murph agent runtime support#106
Conversation
|
@codex Review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b8beabad2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!toolId) { | ||
| break; | ||
| } | ||
| ctx.blockToolInputJson.set(index, (ctx.blockToolInputJson.get(index) ?? "") + partialJson); |
There was a problem hiding this comment.
blockToolInputJson is keyed only by index and new deltas are appended to any prior value, but the map is never cleared when a new content_block_start for tool_use arrives at the same index. In streams with multiple assistant messages (common after tool results), index values restart from 0, so a later tool call can inherit stale JSON from an earlier one; this can make JSON.parse fail at content_block_stop and suppress message.tool_call_input_end, or parse the wrong input payload for the UI.
Useful? React with 👍 / 👎.
|
@codex Review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex Review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Adds optional Murph agent runtime support while keeping existing behavior as the default.
Validation: