Skip to content

fix: complex object not copyable from cell context menu#2545

Merged
ghiscoding merged 2 commits intomasterfrom
bugfix/context-copy-complex-object
Apr 23, 2026
Merged

fix: complex object not copyable from cell context menu#2545
ghiscoding merged 2 commits intomasterfrom
bugfix/context-copy-complex-object

Conversation

@ghiscoding
Copy link
Copy Markdown
Owner

@ghiscoding ghiscoding commented Apr 23, 2026

the "Copy" command wasn't enabled when data was a complex object (dot notation), this PR fixes that by detecting if the field had a dot notation and is using Formatters.complex, basically it now uses the same code to detect if the command should be enabled & copy the cell value.

I also assume that it's a bug that was in place since the Copy command was introduced, or in other words it was always a bug and now it's fixed :)

Co-authored-by: Copilot <copilot@github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (ad3ca06) to head (4f04b70).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2545   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         196      196           
  Lines       24964    24958    -6     
  Branches     8814     8811    -3     
=======================================
- Hits        24964    24958    -6     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 23, 2026

angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2545

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2545

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2545

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2545

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2545

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2545

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2545

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2545

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2545

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2545

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2545

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2545

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2545

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2545

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2545

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2545

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2545

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2545

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2545

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2545

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2545

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2545

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2545

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2545

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2545

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2545

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2545

commit: 4f04b70

Co-authored-by: Copilot <copilot@github.com>
@ghiscoding ghiscoding merged commit a1f0fdd into master Apr 23, 2026
14 checks passed
@ghiscoding ghiscoding deleted the bugfix/context-copy-complex-object branch April 23, 2026 13:41
@github-actions
Copy link
Copy Markdown

🎉 This pull request is included in version 10.5.2 📦
🔗 The release notes are available at: GitHub Release 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant